Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495398 --- Comment #4 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2009-04-15 02:00:22 EDT --- There's an examples/ directory; why not include it in %doc? There are a slew of rpmlint errors -- these are all related to the execute bit being set on our .pm's. I find that including the following in %prep usually makes rpmlint happy: find . -type f -exec chmod -c -x {} \; Fix the rpmlint errors and warning, include examples/ in %doc and I'll approve. :-) koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1299603 Spec looks sane, clean and consistent; license is correct (BSD); make test passes cleanly. Source tarballs match upstream (sha1sum): 4ce2c0b734b2393f49f857f686b835bb2919eb05 Net-UPnP-1.41.tar.gz 4ce2c0b734b2393f49f857f686b835bb2919eb05 Net-UPnP-1.41.tar.gz.srpm Final provides / requires are sane: perl-Net-UPnP.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 0 packages and 1 specfiles checked; 0 errors, 1 warnings. =====> perl-Net-UPnP-1.41-2.fc10.src.rpm <===== ====> rpmlint perl-Net-UPnP.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides for perl-Net-UPnP-1.41-2.fc10.src.rpm ====> requires for perl-Net-UPnP-1.41-2.fc10.src.rpm perl(ExtUtils::MakeMaker) perl(Test::More) =====> perl-Net-UPnP-1.41-2.fc10.noarch.rpm <===== ====> rpmlint perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/Device.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/AV/MediaServer.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/ControlPoint.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/Service.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/AV/MediaRenderer.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/AV/Content.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/HTTPResponse.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/QueryResponse.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/AV/Item.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/ActionResponse.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/GW/Gateway.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/HTTP.pm perl-Net-UPnP.noarch: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Net/UPnP/AV/Container.pm 1 packages and 0 specfiles checked; 13 errors, 0 warnings. ====> provides for perl-Net-UPnP-1.41-2.fc10.noarch.rpm perl(Net::UPnP) = 1.41 perl(Net::UPnP::AV::Container) perl(Net::UPnP::AV::Content) perl(Net::UPnP::AV::Item) perl(Net::UPnP::AV::MediaRenderer) perl(Net::UPnP::AV::MediaServer) perl(Net::UPnP::ActionResponse) perl(Net::UPnP::ControlPoint) perl(Net::UPnP::Device) perl(Net::UPnP::GW::Gateway) perl(Net::UPnP::HTTP) perl(Net::UPnP::HTTPResponse) perl(Net::UPnP::QueryResponse) perl(Net::UPnP::Service) perl-Net-UPnP = 1.41-2.fc10 ====> requires for perl-Net-UPnP-1.41-2.fc10.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Net::UPnP) perl(Net::UPnP::AV::Container) perl(Net::UPnP::AV::Content) perl(Net::UPnP::AV::Item) perl(Net::UPnP::ActionResponse) perl(Net::UPnP::Device) perl(Net::UPnP::HTTP) perl(Net::UPnP::HTTPResponse) perl(Net::UPnP::QueryResponse) perl(Net::UPnP::Service) perl(Socket) perl(strict) perl(vars) perl(warnings) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review