Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488995 --- Comment #5 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2009-04-14 17:47:11 EDT --- (In reply to comment #3) > >> please use commands like they are, not as a macro. > >> make instead of %{__make} > > OK, but what's wrong with using macros? > Nothing, it's just a sugestion. I would prefer make, so I tried to convince > you. If you don't like it, you can use macros of course, if you want. Changed. > >> %defattr(644,root,root,755) > >> please use %defattr(-,root,root,-) > > Why? > This is the part you should answer why you are not using > %defattr(-,root,root,-) > https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions > If you have a good reason to differ from default, I will have no problem with > this. I don't. Changed. > > No, it has its own implementation. I'm not sure if it makes sense to ask > > upstream to use libtlen because libtlen hasn't been updated in quite a while. > That puts another complexion on the matter. > https://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries It's not duplication, because the code is different (only auth.c is taken from an older release of libtlen). Anyway, I've sent upstream an email asking about libtlen usage. http://rathann.fedorapeople.org/review/pidgin-tlen.spec http://rathann.fedorapeople.org/review/pidgin-tlen-0-0.2.20090209.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review