Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491128 --- Comment #15 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-04-14 14:33:15 EDT --- Created an attachment (id=339539) --> (https://bugzilla.redhat.com/attachment.cgi?id=339539) Patch to compile with g++44 Some notes: * Summary - Fedora now considers that duplicating package name in Summary is just redundant. * License - tag should just be "GPLv2+" for this package. All files licensed under different licenses than GPLv2+ are used individably with files under GPLv2+ and GPLv2+ transcends all other licenses in this case. * BuildRequires - "BuildRequires: gtk+-devel" is not needed This is GTK+ version 2 package, while "gtk+-devel" on Fedora is for GTK+ version 1 package. And "gtk2-devel" is required by gutenprint-devel so "BuildRequires: gtk2-devel" is not needed, either. * Build Failure - Your srpm won't build on dist-f11 (using g++ 4.4). http://koji.fedoraproject.org/koji/taskinfo?taskID=1298108 The attached patch is needed. * Timestamps - Use "-p" option when installing files using "cp" or "install" commands to keep timestamps on installed files: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Scriptlets - Scriptlets for GTK icon cache update is updated: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review