Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495411 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-04-14 02:06:35 EDT --- Okay, here is a more thorough review: * rpmlint says: dnsjava.src:106: W: libdir-macro-in-noarch-package (main package) This one is a false warning and can be ignored dnsjava.x86_64: W: file-not-utf8 /usr/share/doc/dnsjava-2.0.6/Changelog We need to fix this. "iconv" will help. ! There are some example .java files in the root of the tarball. Their usage are explained in the USAGE file. I think these .java files need to go to %doc (of the main package). Alternatively, you can build them and put them in %{_datadir}/%{name} or so. (You mention about these files in the %description too) * There is a tests directory. The README file mentions about building and running these compile tests. We should make a %check section and run these tests, if possible. ? Shouldn't the group tag be "System Environment/Libraries"? ! Since you are building the javadoc from source, you can remove the existing doc/ directory in %prep * README file says: "dnsjava is placed under the BSD license. Several files are also under additional licenses; see the individual files for details." I found that the files org/xbill/DNS/Tokenizer.java, org/xbill/DNS/ZoneTransferIn.java are licensed under MIT This makes the license BSD and MIT * This comment contains single % macro #ant -Dj2se.javadoc=%{_javadocdir}/java clean docsclean dnssec jar docs Do we need this comment? ! Also these comments are not needed. They can be removed: #Epoch: 0 #Vendor: JPackage Project #Distribution: JPackage * This changelog entry contains single % macro - In Source0 tag inject %%{name} and %{version} macroses. (Also macroses->macros) * "%attr(-,root,root)" is redundant in the line %attr(-,root,root) %{_libdir}/gcj/%{name} I reported this to java folks a while ago. They still didn't fix this guideline. ! In the description, please separate the paragraphs with blanks lines. It'll look better. * These BR's seem unnecessary: jce, java-javadoc * BR: jpackage-utils is listed twice. * You don't want to write "specific_version" in Requires. If you need to pull openjdk-devel instead of gcj-devel, you can use something like >=1.7 or >=1:1.6.0 * Also use the same number (>=1.7 or >=1:1.6.0) for Requires: java -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review