Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492898 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-04-13 05:19:15 EDT --- I reviewed this package. There are a few minor things to go over: * The binary .mo files need to be removed in %prep and be built from the source .po files. * lib/sqlalchemy shouldn't be packaged since it is a duplicate of the python-sqlalchemy package. ! I don't think issuing "make" is necessary. It doesn't build anything. Hence the %build section should be empty. ! Please make the description span 80 columns, AND/OR separate new paragraphs by blank lines. ! Normally, I prefer supplying such wrapper scripts as separate sources. This is also useful to preserve the original creation date. Since it is such a small and trivial script in this case, it shouldn't matter. But I leave it up to your consideration. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review