Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493684 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #9 from Lubomir Rintel <lkundrak@xxxxx> 2009-04-11 12:33:50 EDT --- Thanks a lot for review, Christoph! (In reply to comment #8) > (In reply to comment #5) > > Excuse me? What exactly makes this unreviewable. > > I did not say it was "unreviewable" but that a review at that point did "not > make much sense". The package contained a blocker (COPYING not included), but > the main reason was that it was not the latest version. We are reviewing SRPMs, > not the specs, so strictly speaking after updating the package I would have to > perform another review. We don't do new reviews for new versions once the package is CVS anyways. It would surely block approval, but I don't see why would it block doing a full review. Reviewer's choice anyway > > No problem, no documentation included by upstream. > > COPYING _is_ documentation. It was not present in 1.4. In fact, 1.4 was the latest version at the time the review request was last updated (in fact I made upstream release that version to address our concerns). > Package is APPROVED, but please don't forget to remove the 2nd COPYING after > import into CVS. Sure. :) New Package CVS Request ======================= Package Name: clearlooks-compact-gnome-theme Short Description: GNOME Desktop theme optimized for small displays Owners: sindrepb, lkundrak Branches: F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review