Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493603 Lucian Langa <cooly@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Lucian Langa <cooly@xxxxxxxxxxxx> 2009-04-11 09:02:05 EDT --- This is is a simple program, it builds fine and rpmlint is silent. I note there are several sites where this program is distributed. There are tar.gz version of this package and seems a little smaller than tar.Z is there any reason not to use the smaller package ? Perhaps later would make sense to provide a xinitrc.d file to start this automatically when X is started. OK source files match upstream: 726e829b41e9cb4d6a14cd91ca7efa02125be2be unclutter-8.tar.Z OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK summary a short and concise description. OK description is OK - using alternate suggested text OK dist tag is present. OK build root is sane. OK license field matches the actual license. OK license is open source-compatible. OK license text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (rawhide, x86_64). OK package installs properly. OK debuginfo package looks complete. OK rpmlint is silent. Ok final provides and requires are sane: unclutter = 8-1.fc11 unclutter(x86-64) = 8-1.fc11 = libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) OK %check there's no test suite upstream; I was able to run this program and it works as exected. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review