Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226341 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-11 06:32:43 EDT --- - What is the stuff at the beginning needed for? - You can use %{!?pyver: %global pyver %(%{__python} -c "import sys ; print sys.version[:3]")} to get the Python base version. - Patches are not documented. - Commented patches should be removed. - BuildRoot should be %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) - Remove topdir, pushd and popd and use make -C Doc instead. - Remove buildroot check from install. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review