Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493684 --- Comment #5 from Lubomir Rintel <lkundrak@xxxxx> 2009-04-11 05:46:35 EDT --- (In reply to comment #4) > You package has a couple of issues that it does not make much sense to review > it at this point: Excuse me? What exactly makes this unreviewable. > $ rpmlint > /var/lib/mock/fedora-rawhide-i386/result/clearlooks-compact-gnome-theme-1.4-2.fc11.* > clearlooks-compact-gnome-theme.noarch: W: incoherent-version-in-changelog 1.4-1 > ['1.4-2.fc11', '1.4-2'] Will fix. > clearlooks-compact-gnome-theme.noarch: W: no-documentation No problem, no documentation included by upstream. > clearlooks-compact-gnome-theme.src:16: W: unversioned-explicit-provides > clearlooks-compact > > Fix the changelog and include COPYING to make the the no docs warning > disappear. Change the provides to > Provides: clearlooks-compact = %{version} Done. > The license is not clear to me. COPYING from the source is LGPLv2.1, but you > say it's GPLv2+. Pardon me? I read this there: License: LGPLv2+ COPYING file does not determine which licensing terms are in use. Comments in files do. COPYING merely contains the license text. > There is a new version available, see > http://martin.ankerl.com/files/ClearlooksCompact-1.5.tar.bz2 Updated. SPEC: http://v3.sk/~lkundrak/SPECS/clearlooks-compact-gnome-theme.spec SRPM: http://v3.sk/~lkundrak/SRPMS/clearlooks-compact-gnome-theme-1.5-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review