Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495284 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2009-04-11 03:13:18 EDT --- + source files match upstream. 60628a9ee8c72852d08ebcdfb7090a58d8b044bb CSS-Minifier-XS-0.03.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1290530 + package installs properly. + rpmlint has no complaints: perl-CSS-Minifier-XS.src: I: checking perl-CSS-Minifier-XS.x86_64: I: checking perl-CSS-Minifier-XS-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(CSS::Minifier::XS) = 0.03 perl-CSS-Minifier-XS = 0.03-1.fc11 perl-CSS-Minifier-XS(x86-64) = 0.03-1.fc11 = perl(:MODULE_COMPAT_5.10.0) rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(VersionedDependencies) <= 3.0.3-1 libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) perl >= 0:5.006 perl(DynaLoader) perl(Exporter) perl(strict) perl(warnings) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) + %check is present and all tests pass. t/01-loads.t ................ ok t/02-minify.t ............... ok t/03-minifies-to-nothing.t .. ok t/99-benchmark.t ............ skipped: CSS::Minifier not available for benchmark comparison t/pod-coverage.t ............ ok t/pod.t ..................... ok All tests successful. Files=6, Tests=12, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.46 cusr 0.03 csys = 0.55 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. I assume that perl-CSS-Minifier is on its way soon to complete the test suite. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review