Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494872 --- Comment #5 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2009-04-10 20:35:17 EDT --- Things to fix: 1) The test suite needs to be run in %clean, or a compelling justification as to why not needs to be given. This includes adding as BR's all modules required to run the full test suite. (With the exception of Test::Pod::Coverage and Test::Perl::Critic). 2) While there is indeed a Build.PL, this module is actually using Module::Install, and cpanspec is getting it wrong by picking the Module::Build incantations over ExtUtils::MakeMaker/Module::Install. Modern versions of M::I have dropped support for the M::B style, so it's probably best we don't go that route. (For a typical specfile with EU::MM style build/install, run "rpmdev-newspec -t perl".) Things to think about: 1) It looks like all but one of the manual "Requires:" lines you have in the spec are redundant against the auto-generated requires; I wouldn't leave them in but they don't harm anything, so I'm not going to consider them blockers. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1290136 Source tarballs match upstream (sha1sum): 646bba8987696dbf2fca7fcb633cd907b370a8c6 Data-ObjectDriver-0.05.tar.gz 646bba8987696dbf2fca7fcb633cd907b370a8c6 Data-ObjectDriver-0.05.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Data-ObjectDriver-0.05-1.fc10.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Data-ObjectDriver-0.05-1.fc10.src.rpm ====> requires for perl-Data-ObjectDriver-0.05-1.fc10.src.rpm perl(Class::Accessor::Fast) perl(Class::Data::Inheritable) perl(Class::Trigger) perl(DBI) perl(Module::Build) perl(Test::Exception) perl(Text::SimpleTable) =====> perl-Data-ObjectDriver-0.05-1.fc10.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Data-ObjectDriver-0.05-1.fc10.noarch.rpm perl(Data::ObjectDriver) = 0.05 perl(Data::ObjectDriver::BaseObject) perl(Data::ObjectDriver::BaseView) perl(Data::ObjectDriver::Driver::BaseCache) perl(Data::ObjectDriver::Driver::Cache::Apache) perl(Data::ObjectDriver::Driver::Cache::Cache) perl(Data::ObjectDriver::Driver::Cache::Memcached) perl(Data::ObjectDriver::Driver::Cache::RAM) perl(Data::ObjectDriver::Driver::DBD) perl(Data::ObjectDriver::Driver::DBD::Pg) perl(Data::ObjectDriver::Driver::DBD::SQLite) perl(Data::ObjectDriver::Driver::DBD::mysql) perl(Data::ObjectDriver::Driver::DBI) perl(Data::ObjectDriver::Driver::MultiPartition) perl(Data::ObjectDriver::Driver::Multiplexer) perl(Data::ObjectDriver::Driver::Partition) perl(Data::ObjectDriver::Driver::SimplePartition) perl(Data::ObjectDriver::Errors) perl(Data::ObjectDriver::Iterator) perl(Data::ObjectDriver::Profiler) perl(Data::ObjectDriver::ResultSet) perl(Data::ObjectDriver::SQL) perl-Data-ObjectDriver = 0.05-1.fc10 ====> requires for perl-Data-ObjectDriver-0.05-1.fc10.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Class::Accessor::Fast) perl(Class::Accessor::Fast) perl(Class::Data::Inheritable) perl(Class::Trigger) perl(Class::Trigger) perl(DBI) perl(DBI) perl(Data::Dumper) perl(Data::ObjectDriver::Driver::DBD) perl(Data::ObjectDriver::Driver::MultiPartition) perl(Data::ObjectDriver::Errors) perl(Data::ObjectDriver::Iterator) perl(Data::ObjectDriver::ResultSet) perl(Data::ObjectDriver::SQL) perl(List::Util) perl(Storable) perl(Text::SimpleTable) perl(base) perl(constant) perl(strict) perl(warnings) Switch the prep/build/install/test incantations to ExtUtils::MakeMaker and enable the test suite (or convince me why it should remain disabled) and I'll approve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review