Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495001 --- Comment #1 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> 2009-04-09 17:36:16 EDT --- a short resume of the fist touch (about 5 minutes) !!THE PACKAGE WON'T BUILD!! --missing BRs gettext perl-XML-Parser --missing Rs hicolor-icon-theme --- macros please use name macro instead of name --- permissions executing of *.dll is not necessary (didn't check this) --- ownage %{_libdir}/bareftp/bareFTP.Common.Utils.dll %{_libdir}/bareftp/bareFTP.Connection.dll %{_libdir}/bareftp/bareFTP.Gui.Dialog.dll %{_libdir}/bareftp/bareFTP.Gui.FileManager.dll %{_libdir}/bareftp/bareFTP.Gui.Preferences.dll %{_libdir}/bareftp/bareFTP.Gui.ProgressMonitor.dll %{_libdir}/bareftp/bareFTP.Gui.dll %{_libdir}/bareftp/bareFTP.Preferences.dll %{_libdir}/bareftp/bareFTP.Protocol.Ftp.dll %{_libdir}/bareftp/bareFTP.Protocol.Sftp.dll %{_libdir}/bareftp/bareFTP.Protocol.dll %{_libdir}/bareftp/bareftp.exe you own every file in the directory, but not the directory itself. %{_libdir}/%{name}/ instead of the list above would own the directory and all the files in it. --- filesection your: %{_bindir}/bareftp %{_datadir}/icons/hicolor/*/*/*.png %{_datadir}/icons/hicolor/*/*/*.svg %{_datadir}/applications/*.desktop i would write: %{_bindir}/%{name} %{_datadir}/applications/%{name}.desktop %{_datadir}/icons/hicolor/*/apps/%{name}.* --- docs INSTALL is not important for end-users, because YOU did the installation! please remove it --- timestamps make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" to preserve timestamps --- rpmlint bareftp.i386: E: no-binary bareftp.i386: W: only-non-binary-in-usr-lib bareftp-debuginfo.i386: E: empty-debuginfo-package --- License please check this again --- Name of this bug bareftp - File transfer client supporting the FTP, FTP over SSL/TLS (FTPS) and SSH File Transfer Protocol (SFTP) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review