Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=477750 --- Comment #7 from Matthias Saou <matthias@xxxxxxxxxxxx> 2009-04-09 13:35:33 EDT --- * /!\ rpmlint output : ogmtools.x86_64: W: file-not-utf8 /usr/share/doc/ogmtools-1.5/ChangeLog That will need fixing, like Paulo suggested for instance. * OK : naming is ok, spec is named ok, confirms to packaging guielines * /!\ license is GPL+ from what I dug up, please confirm then fix in the License * OK : sources are pristine * OK : builds and runs fine (tested on x86_64) * OK : build requires are ok, though libogg-devel could be excluded since libvorbis-devel requires it, but since the package explicitly requires libogg to build this is fine * OK : no libs, not relocatable, no unusual parent dirs * OK : %files, %clean, %defattr, consistency in macros * OK : no devel type files, no large docs * OK : no GUI, no .desktop file Cosmetic : The header lines aren't aligned with the BuildRequires ones. Please fix the ChangeLog file, the "License:" field and align the headers in the spec if you don't mind. Once that done, I'll approve the package. (and sorry for having stalled the review for so long, I really had hope to be able to get it over with much more quickly) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review