Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493247 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-04-09 12:33:08 EDT --- Some notes for 0.16-2: * License - The license tag "Distributable, see LICENSE" is invalid. For this package the license tag should be "LGPLv2+". * BuildRequires: - The following BR is invalid: --------------------------------------------------------------- BuildRequires: libwnck-devel >= @GNOME_WNCK@ --------------------------------------------------------------- * Requires - The following Requires are redundant. rpmbuild should automatically detect these dependencies --------------------------------------------------------------- Requires: perl(ExtUtils::Depends) >= 0.20 Requires: perl(ExtUtils::PkgConfig) >= 1.03 Requires: perl(Glib) >= 1.180 Requires: perl(Gtk2) >= 1.00 --------------------------------------------------------------- - The following misses the last ")" --------------------------------------------------------------- Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version) --------------------------------------------------------------- * Make build.log more verbose (and also on the bug 493250) - The current build.log shows: --------------------------------------------------------------- 62 chmod 644 Wnck.bs 63 [ CC xs/Wnck.c ] 64 [ CC xs/WnckApplication.c ] 65 [ CC xs/WnckClassGroup.c ] 66 [ CC xs/WnckPager.c ] --------------------------------------------------------------- This is not useful, e.g. we cannot check if Fedora specific compilation flags are correctly honored. The following method will show more verbose message, however there may be some other method (Parag, would you know?) --------------------------------------------------------------- make %{?_smp_mflags} NOECHO= --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review