Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225974 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pmatilai@xxxxxxxxxx Flag|fedora-cvs+ |fedora-cvs? --- Comment #10 from Jon Ciesla <limb@xxxxxxxxxxxx> 2009-04-09 10:09:17 EDT --- Ok, let's see. >> krb5.src: W: strange-permission krb5kdc.init 0755 >> A file that you listed to include in your package has strange permissions. >> Usually, a file should have 0644 permissions. > >I'm gonna need help from CVS admins for this one -- the permissions are set at >checkout-time. Yeah, it was probably set this way when the SRPM that was imported was built. I'll set the CVS flag again for assistance. >> krb5.src: W: strange-permission krb5-tex-pdf.sh 0755 >> A file that you listed to include in your package has strange permissions. >> Usually, a file should have 0644 permissions. > >We run this script during the build. We could take the execute bit off and run >a shell with the script as its argument, I guess. Probably worth doing. >> krb5-libs.i386: W: hidden-file-or-dir /usr/kerberos/man/man5/.k5login.5.gz >> The file or directory is hidden. You should see if this is normal, and delete >> it from the package if not. >> >> ??????????? > >This is the man page for the use of ~/.k5login. Not really sure what to do >with it. Since it's a valid manpage with a valid name, file a bug for an rpmlint exception. >> krb5-workstation.i386: E: setuid-binary /usr/kerberos/bin/ksu root 04755 >> The file is setuid, this may be dangerous, especially if this file is setuid >> root. >> >> Necessary, I suspect. > >Yup. For a while we took the setuid bit off, but it's actually useless without >it, and the bug reports were rarely friendly. I can imagine. :) rpmlint exception here, too. >> krb5-workstation.i386: W: unstripped-binary-or-object /usr/kerberos/bin/ksu >> >> Fix if possible. > >The buildroot strip script misses setuid applications. I'm actually not sure >if that's intentional or not. CCing Panu for this one. >> krb5-workstation-servers.i386: E: postin-without-chkconfig >> /etc/rc.d/init.d/krb524 >> The package contains an init script but doesn't call chkconfig in its %post. >> >> krb5-workstation-servers.i386: E: init-script-without-chkconfig-preun >> /etc/rc.d/init.d/krb524 >> The package contains an init script but doesn't contain a %preun with a call >> to chkconfig. >> >> Probably needs fixing. > >The logic for figuring out which subpackage should chkconfig --del the symlinks >would have been a nightmare. But it's krb4-specific, so triggering on removal >of the older version of either subpackage isn't that bad. (Except for the part >where it's a trigger, and triggers are best avoided if possible.) Am I to understand that this will be deprecated upon removal of krb4 stuff? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review