Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494647 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> 2009-04-08 15:42:58 EDT --- Okay, now it looks like this bit of %install ... # Fix an issue that occurs in the info files (not quite sure where in # the process, so doing it here): mv %{buildroot}%{_infodir}/mmm.info-2.gz \ %{buildroot}%{_infodir}/mmm.info-2 && \ gzip %{buildroot}%{_infodir}/mmm.info-2 ... is no longer necessary. At least, it wasn't necessary for me. MUST items: - rpmlint output: emacs-mmm-el.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. - package name - spec file name - packaging guidelines - Fedora approved license - license field matches actual license - license file in %doc - spec file in American English - spec file is legible - sources match upstream - builds on at least one primary arch - use of ExcludeArch (N/A) - build dependencies in BuildRequires - locale handling (N/A) - call ldconfig (N/A) - relocatable package (N/A) - own all created directories - no duplicates in %files - proper permissions - %clean section - consistent use of macros - code or permissible content - large documentation in -doc (N/A) - nothing in %doc needed at runtime - header files in -devel (N/A) - static libraries in -static (N/A) - Requires pkgconfig (N/A) - .so files in -devel (N/A) - -devel requires main package (N/A) - no libtool archives (N/A) - desktop file (N/A) - do not own previously owned dirs - clean at start of %install - filenames are valid UTF-8 SHOULD items: - ask upstream to include license file (N/A) - supply available translations (N/A) ? package builds in mock (didn't check) ? builds on all supported arches (didn't check) - package functions as described - sane scriptlets - subpackages require main package - pkgconfig file in -devel (N/A) - file vs. package dependencies Looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review