[Bug 226381] Merge Review: ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226381





--- Comment #28 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx>  2009-04-08 13:26:07 EDT ---
Sorry for delay.
With the scriptlets in your comment 27:

------------------------------------------------------
            (
                iconv -f euc-jp -t utf-8 $i > $i.new \
                    && mv $i.new $i \
                    || rm -f $i.new
            )
------------------------------------------------------
will always exit with 0 (unless "rm -f" fails with some _very_
strange reason) and the latter 
------------------------------------------------------
        if [ $? != 0 ]; then
            iconv -f iso8859-1 -t utf-8 $i > $.new \
                && mv $i.new $i \
                || rm -f $i.new
        fi
------------------------------------------------------
will never be executed. i.e. the first "exit 1" before )
need not be changed, the latter "|| exit 1" has to be
changed to "|| rm -f $i.new" as you wrote.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]