Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225784 Michal Nowak <mnowak@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mnowak@xxxxxxxxxx, | |skasal@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mnowak@xxxxxxxxxx Flag| |fedora-review?, | |needinfo?(skasal@xxxxxxxxxx | |) --- Comment #11 from Michal Nowak <mnowak@xxxxxxxxxx> 2009-04-08 12:02:27 EDT --- * rpmlint gdbm.spec: E: non-utf8-spec-file gdbm.spec newman@dhcp-lab-124 SPECS $ file gdbm.spec gdbm.spec: ISO-8859 English text gdbm.spec:30: E: prereq-use /sbin/install-info """ The use of PreReq is deprecated. In the majority of cases, a plain Requires is enough and the right thing to do. Sometimes Requires(pre), Requires(post), Requires(preun) and/or Requires(postun) can also be used instead of PreReq. """ gdbm.src: W: summary-ended-with-dot A GNU set of database routines which use extensible hashing. > Summary: A GNU set of database routines which use extensible hashing. gdbm.x86_64: W: shared-lib-calls-exit /usr/lib64/libgdbm.so.2.0.0 exit@xxxxxxxxxxx gdbm.x86_64: W: shared-lib-calls-exit /usr/lib64/libgdbm.so.2.0.0 exit@@GLIBC_2.2.5 Should be investigated. * 1.8.3 was released but not sure whether is it good idea to incorporate it * Patch0: gdbm-1.8.0-jbj.patch Patch1: gdbm-1.8.0-fhs.patch Patch3: gdbm-1.8.0-64offset.patch Could be: 0-1-2 * Source: ftp://ftp.gnu.org/gnu/gdbm-%{version}.tar.gz is wrong, correct it to Source: ftp://ftp.gnu.org/gnu/gdbm/gdbm-%{version}.tar.gz * > BuildRoot: %{_tmppath}/%{name}-%{version}-root https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * -devel: Requires: gdbm = %{version} https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package * Generally, depend on packages not files with full path: Prereq: /sbin/install-info this might also be the case where you can safely depend on "info"package. * Consistency with the "-p1" option %patch1 -p 1 -b .fhs %patch3 -p1 -b .offset * > # refresh config.sub, the original one does not recognize "redhat" > # as vendorname: > for f in /usr/share/automake-1.1?/config.sub; do > : > done > cp -p $f . > libtoolize --force --copy > aclocal > autoconf Perhaps autoreconf and patching the build system seems better to me. But not that important. * discouraged: %makeinstall install-compat https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used * %defattr(-,root,root) -> %defattr(-,root,root,-) (twice in spec) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review