[Bug 494845] Review Request: xdrfile - A small C-library for reading and writing GROMACS trr and xtc files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494845





--- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx>  2009-04-08 07:36:45 EDT ---
> Currently there's no license included and two header files
> specify the GPLv2+ license instead of BSD.  

This asks for a licence clarification from upstream.


> xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/README
> xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/ChangeLog
> xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/AUTHORS
> xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/COPYING
> xdrfile.x86_64: E: zero-length /usr/share/doc/xdrfile-1.0/NEWS

Hint: There are ways to avoid this.

%prep
%setup ...
## Exit build if these %doc files become non-empty and are added to %files.
[ -s AUTHORS ] && exit 1    # exit if file has non-zero size
#[ -s AUTHORS ] || exit 1   # exit if file has zero size
[ -s COPYING ] && exit 1
#[ -s COPYING ] || exit 1

%files
...
#doc AUTHORS
#doc COPYING
...


> %post devel -p /sbin/ldconfig
> %postun devel -p /sbin/ldconfig

These are wrong and ought to be deleted.


> # Move include files to %{_includedir} instead
> mv %{buildroot}/%{_includedir}/%{name}/*  %{buildroot}/%{_includedir}
> rmdir %{buildroot}/%{_includedir}/%{name}

Better ask upstream for confirmation and a fix in the tarball. The headers need
this change for 'include "xdrfile.h"' to work, but it changes the API because
users of this library can no longer "#include <xdrfile/xdrfile.h>".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]