Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493638 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2009-04-07 16:18:29 EDT --- > I won't mention the things that are okay. In many cases, it is worth mentioning, esp some important ones like mentioning licensing checks/audits, source checksums, scriptlets, rpmlint output... Otherwise nucleo is right (wrt locales), but for buildroot consistency, use the same buildroot reference, ie, dont' use ${RPM_BUILD_ROOT} in one place and $RPM_BUILD_ROOT in another. Otherwise, looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review