Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 --- Comment #27 from Ondrej Vasik <ovasik@xxxxxxxxxx> 2009-04-07 08:32:34 EDT --- Sorry for few days delay... + package builds in mock (development i386). + rpmlint is NOT silent for SRPM links.src:37: W: unversioned-explicit-provides webclient links.src:38: W: unversioned-explicit-provides text-www-browser - common for those provides in existing packages - could be ignored links.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 37) - should be fixed + rpmlint is NOT silent for RPM. links.i586: W: non-executable-in-bin /usr/bin/links 0644 - I guess this is just rpmlint noise, as /usr/bin/links is only via alternatives and should be ignored links.i586: E: invalid-desktopfile /usr/share/applications/links.desktop - links.desktop: error: required key "Encoding" not found + source files match upstream. bf5b20529a2a811701c5af52b28ebdd4 links-2.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is NOT included in package. - COPYING file should be shipped + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc files. + no .la files. + menu translations are available in binary + Does own the directories it creates (none special created) + no duplicates in %files. + file permissions are appropriate (ignoring false-positive rpmlint warning about ghosted touched file/future alternative symlink). + GUI app with desktop file (expecting addition of Encoding line) and icon Required to fix: - Add Encoding=UTF-8 line to desktop file - Do ship COPYING in %doc - fix mixed tab/spaces and previously mentioned things in spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review