Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 --- Comment #19 from David Nielsen <gnomeuser@xxxxxxxxx> 2009-04-07 05:37:45 EDT --- Maybe that is the case, it is my impression that using flags one could specifically tell rpmbuild to build things like --with-evolution and so on so you could build the separated plugins. However that would require being able to run the configure script in such a way as to disable the undesired plugins and knowing the gnome-do guys this will not be possible. I doubt we can do this on second thought. Also regarding the excludes, I rewrote the spec you referenced for greater flexibility and I don't remember doing that.. maybe I did and forgot about it. I'll chuck this up to rpm being suboptimal for maintainers here and not doing the right thing by default. Doesn't this contain language files? Regardless I can do a proper review on Thursday, I had my account reenabled so I should also be able to approve it. A quick overview looks very good though. Why is the banshee exclude commented out? Aside that there's a cosmetic enhancement ensuring an equal amount of newlines between the the main package and the plugins packages file listings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review