Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492122 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalev@xxxxxxxxxxxx Bug 492122 depends on bug 492110, which changed state. Bug 492110 Summary: Review Request: mingw32-libsigc++20 - MinGW Windows port of the typesafe signal framework for C++ https://bugzilla.redhat.com/show_bug.cgi?id=492110 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED --- Comment #1 from Kalev Lember <kalev@xxxxxxxxxxxx> 2009-04-07 04:12:55 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1281702 Rpmlint is quiet: $ rpmlint mingw32-cairomm-1.8.0-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint mingw32-cairomm-1.8.0-1.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + OK ! needs attention + rpmlint output + Package is named according to Fedora MinGW packaging guidelines + Specfile name matches the package base name + Package follows the Fedora MinGW packaging guidelines + License meets guidelines and is acceptable to Fedora LGPLv2+ + License matches the actual package license It is also the same as in the corresponding Fedora cairomm package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm 15c0f56eee57bb418c38463a6297d715 cairomm-1.8.0.tar.gz 15c0f56eee57bb418c38463a6297d715 SRPM/cairomm-1.8.0.tar.gz + Package builds in mock (Fedora Rawhide i586) n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static + Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 Note: I am not in packager group, so I cannot set fedora‑review+ flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review