Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493638 --- Comment #2 from nucleo <alekcejk@xxxxxxxxxxxxxx> 2009-04-07 02:25:44 EDT --- (In reply to comment #1) > MUST: The spec file MUST handle locales properly. This is done by using the > %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] NOT_DONE This package doesn't includes any translations files in %{_datadir}/locale/* %find_lang is useless in this package. http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files > MUST: Each package must consistently use macros. (see line 34 and 38, > $RPM_BUILD_ROOT ond ${RPM_BUILD_ROOT} This style of defining the rpm Build Root can be used. http://fedoraproject.org/wiki/Packaging /Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review