Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493638 Armin <feng.shaun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |feng.shaun@xxxxxxxxx --- Comment #1 from Armin <feng.shaun@xxxxxxxxx> 2009-04-06 22:27:07 EDT --- I won't mention the things that are okay. MUST: MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] NOT_DONE MUST: Each package must consistently use macros. (see line 34 and 38, $RPM_BUILD_ROOT ond ${RPM_BUILD_ROOT} SHOULD: nothing (yet) I will continue the rest of the review tomorrow. It's not complete yet. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review