Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493250 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-04-06 13:53:55 EDT --- Looks much better. Some points * Explicit Requires: ----------------------------------------------------- Requires: perl(Cairo) >= 1.00 Requires: perl(ExtUtils::Depends) >= 0.2 Requires: perl(ExtUtils::PkgConfig) >= 1.0 Requires: perl(Glib) >= 1.103 Requires: perl(Gtk2) >= 1.100 Requires: gtk2, glib, cairo ----------------------------------------------------- - All of these should be removed. Such perl module related dependencies and library related dependencies are automatically detected by rpmbuild itself. (By the way, I think perl(ExtUtils::Depends), perl(ExtUtils::PkgConfig) is really unneeded) * Directory ownership issue - This package should not own the following directories _themselves_ ----------------------------------------------------- %{_bindir}/ %{_mandir}/man3/ %{_mandir}/man1/ %{perl_vendorarch}/auto/ ----------------------------------------------------- ! Note For example, this package should own %_bindir/perlmine.pl, however should not own the directory %_bindir itself. i.e. change the %files entry to %{_bindir}/* or so. CCing to spot: To spot: This package contains a perl script named "/usr/bin/perltetris.pl". Is this allowed on Fedora? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review