Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453851 --- Comment #10 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> 2009-04-06 12:32:08 EDT --- (In reply to comment #9) > The %post script generates the two files labelled as %ghost in the filelist: > %ghost %{_datadir}/globus/setup/globus-sh-tools-vars.sh > %ghost %{_datadir}/globus/globus-sh-tools-vars.sh And what are these files used for? > I think a script is an overkill here, since the instructions are quite simple > (extract a complete subdirectory) and can be stated in a comment. The reviewer I don't think "overkill" is the right description for a 3 line script. Everytime there is a globus update, you need to: unpack the original archive, pack the two new archives. Now if you write these 3 commands into a script file, I'm happy. Furthermore, Fedora has guidelines for what to do if one has to repack the source archive. They are there for a reason. There has to be a good reason for not following them, and IMO calling a 3 line script "overkill" is not a good enough reason... Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review