Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492164 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-04 09:50:49 EDT --- (In reply to comment #11) > (In reply to comment #10) > > I had a look at the check phases, and realized there'd be no sense in running > > them as they are designed to be interactive. > > I see you've packaged them, I'm fine with that, just moved them to -devel, > since they're of more-or-less no use unless you're a developer, and needlessly > occupy space when dragged in as dependency. Okay, fine by me. > > > Call me a masochist, but I also packaged the C++ stuff. Seemed straightforward > > at first, but the makefile is a bit more sick than Fortran. > > Um, yes, you're insane :) > > I'm honestly hoping that Java bindings aren't going to follow until the package > is imported :) Seriously, you're going to have commit access so why delay the > review with new features. Well, considering how sick the packaging is, I prefer to get everything in the review and make the least changes possible after that. I have no interest in the Java stuff, if anyone needs it then s/he'll have to send a patch :) > > I have fixed these, and the stuff that came up in the review. > > I'm starting to wonder who's the packager and who's reviewer here :) > > If I had been the reviewer, I'd most likely approved the packages now, since > I'm reasonably with your changes now. Anyways, I've done some changes, see the > changelog. Yes, it seems that the spec file has now been mostly written by me :D Well, I guess this kind of thing is normal with software that is as complicated as this. > > healpix.src: W: strange-permission healpix-f90test.sh 0775 > > healpix-c++.x86_64: W: spurious-executable-perm > > /usr/share/doc/healpix-c++-2.11c/test/runtest.sh > > I've fixed the mode, but am not sure what is this script good for. > Why pack this in a separate file and not run it in %check? Because, IIUC, it creates a bunch of images and it's up to the user to check that they make sense. -- We both agree on the contents and that the rpm packaging is sane. The package has been found to adhere to the guidelines and is thus APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review