Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493957 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-03 12:18:33 EDT --- - Don't use macros for cat or rm. (Macro for python is in the python guideline for some reason.) - Don't use filelist. - Use %defattr(-,root,root,-) - Remove empty %post and %postun sections. - Change BuildRequires: python, python-devel, python-setuptools to BuildRequires: python-setuptools-devel (BR python is redundant, since python-devel already pulls that in. If you BR python-setuptools-devel, then it pulls setuptools and python-devel automatically.) Also, you don't even need python-setuptools unless you want to build for EPEL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review