Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470703 Ondrej Vasik <ovasik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikulas@xxxxxxxxxxxxxxxxxxx | |ni.cz --- Comment #25 from Ondrej Vasik <ovasik@xxxxxxxxxx> 2009-04-03 06:10:21 EDT --- (In reply to comment #24) > > Ok, just quick check first... > If I understand correctly, you're planning to do a more detailed review later, > right? In that case, I'll wait with updating the package until then. Yep, I do plan to check&fill review approval template I have step by step... Hopefully today ;) > > 2) > > Many warnings "pointer targets in passing argument <N> of <variable> differ in > > signedness" in build.log still ... upstream should address those... maybe just > > adding Mikulas to that review could be ok. > > Mikulas? Which one? An upstream developer? Exactly... adding him to CC... > > Question: Shouldn't be that NSS support enabled via configure option (like in > > elinks?). This should be easier to get into upstream ... > > It should. In fact, I have little motivation to fix configure scripts gotten > obviously wrong -- see use of random include directories in openssl detection > routine below. > > So my plan is to throw this upstream and rewrite it (and the openssl detection) > only once they complain. I don't really care about user choosing between NSS > and OpenSSL. In general - I'm ok with that - that patch is not very complicated and NSS compat could be full replacement for OpenSSL in that case. I guess that's not review blocker anyway - any maintainer/comaintainer could improve that configure script later to give user a chance to choose which library will be used. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review