Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493530 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-04-02 03:31:01 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1272284 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 87fb75627801e323f7bc4430c3c97334 Data-Dumper-Names-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=13, 0 wallclock secs ( 0.01 usr 0.05 sys + 0.15 cusr 0.03 csys = 0.24 CPU) + Package perl-Data-Dumper-Names-0.03-1.fc11.noarch => Provides: perl(Data::Dumper::Names) = 0.03 Requires: perl(Data::Dumper) perl(PadWalker) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) Suggestions: 1) Please change %description. See what description mean http://fedoraproject.org/wiki/PackagingGuidelines#Summary_and_description 2) Summary should be "Dump variables with names" 3) you don't need following Requires: perl(PadWalker) >= 0.13 Requires: perl(Test::More) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review