Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493247 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-04-01 14:52:53 EDT --- Also see my comment on bug 493250 (By the way I doubt your package builds on your machine...) Then: - Please use canonical cpan site URL for Source0. - @foo@ in BuildRequires is invalid. Also please consider if such explicit version-specific (Build)Requires are really needed. - For perl modules please don't write the rpm name directory as (Build)Requires but write virtual Provides names the rpms provide (BuildRequires: perl(ExtUtils::Depends) or so) https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides - These explicit Requires: ------------------------------------------------------- Requires: libwnck >= %(pkg-config --modversion libwnck-1.0) Requires: perl-Glib >= @PERL_GLIB@ Requires: perl-Gtk2 >= @PERL_GTK@ Requires: gtk2, glib perl-Gtk2, cairo -------------------------------------------------------- should not be needed. Also "Requires: %(perl -MConfig -le 'if (de....." is not needed, I guess. rpmbuild itself should handle these. - Please make %description divided into several lines. - Please add some documents -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review