Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dx - Open source version of IBM's Visualization Data Explorer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203662 paul@xxxxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |paul@xxxxxxxxxxxxxxxxxxxxxx ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-23 17:01 EST ------- Quick notes... Release: 1 - needs the dist License: IBM Public License - is this a valid licence Fedora is happy with? %prep %{__libtoolize} --force %{__aclocal} %{__autoconf} %{__autoheader} %{__automake} -a Is this lot really needed or can the relibtoolize thing work? --with-jni-path=%{java_home}/include \ You need something in the BR if java is going to be used You have %{_libdir}/%{name}/ in files and %{_libdir}/%{name}/samples in samples. As the files has already taken ownership of %{_libdir}/%{name}, does the second one need to be in there? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review