[Bug 491886] Review Request: xa - 6502/65816 cross assembler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491886


Till Maas <opensource@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource@xxxxxxxxx




--- Comment #1 from Till Maas <opensource@xxxxxxxxx>  2009-03-31 07:46:27 EDT ---
- %{_prefix} should be used instead of /usr in %install
- Instead of the chmod a-x for the manpages, you could fix the Makefile to use
install -m 0644 for the manpages.
- you should pass "INSTALL=install -p" to make, to preserve the timestamps of
the manpages
- can you maybe convince upstream to use PREFIX instead of DESTDIR for the
prefix (/usr/local), but add a $(DESTDIR) in install: to follow common
practice?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]