Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488168 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx AssignedTo|petersen@xxxxxxxxxx |panemade@xxxxxxxxx Flag|fedora-review? |fedora-review+ --- Comment #8 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-03-30 04:32:01 EDT --- Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1264871 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8aa15f5b6d1b12068b22ff5e9639a277 ibus-table-wubi-1.1.0.20090327.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + ibus-table-createdb scriptlet used. + file permissions are appropriate. + Not a GUI App. Suggestions: 1) Change license to GPLv3+ 2) Good if you preserve timestamp of svg file also. Use make DESTDIR=%{buildroot} install INSTALL="install -p" APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review