Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492110 Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mattias.ellert@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2009-03-29 13:38:11 EDT --- Fedora review mingw32-libsigc++20-2.2.2-5.fc11.src.rpm (2009-03-29) rpmlint output: mingw32-libsigc++20.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libsigc-2.0.dll.a mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/retype.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/trackable.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/bound_argument.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/bind_return.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/limit_reference.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/bind.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/sigc++.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/bind.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libsigc-2.0.dll.a mingw32-libsigc++20.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libsigc-2.0.dll.a mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/signal_base.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/retype_return.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/functors/ptr_fun.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/deduce_result_type.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/retype.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/lambda/operator.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/sigc++-2.0/include/sigc++config.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/connection.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/compose.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/adaptor_trait.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/lambda/select.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/visit_each.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/slot.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/retype_return.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/bind_return.h mingw32-libsigc++20.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/lib/libsigc-2.0.la mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/functors/slot_base.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/functors/mem_fun.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/class_slot.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/functors/functor_trait.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/signal.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/method_slot.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/lambda/base.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/object.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/type_traits.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/reference_wrapper.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/functors/functors.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/hide.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/hide.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig/sigc++-2.0.pc mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/exception_catch.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/lambda/group.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/object_slot.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/lambda/lambda.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/adaptors/adaptors.h mingw32-libsigc++20.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/sigc++-2.0/sigc++/functors/slot.h mingw32-libsigc++20.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 2 packages and 1 specfiles checked; 2 errors, 46 warnings. Legend: * OK ! Needs attention * rpmlint output - I guess rpmlint was not updated to handle mingw packages very well. The devel-file-in-non-devel-package warnings are of course totally bogus in this case. The same is true for arch-independent-package-contains-binary-or-object and non-standard-dir-in-usr - someone might want to file a bug to rpmlint, so that it stops complaining abou these. The only warnings/errors that make sense are these two: mingw32-libsigc++20.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libsigc-2.0.dll.a mingw32-libsigc++20.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/lib/libsigc-2.0.la These could be fixed by removing the executable permissions on these two files - unless that breaks anything. Windows has a tendency to put executable permissions on everything. * Package is named according to Fedora mingw packaging guidelines * Spec file is named as the package * Package follows the Fedora mingw packaging guidelines * The stated license (LGPLv2+) is a Fedora approved license * The stated license is the same as the one for the corresponding Fedora package * The package contains the license file (COPYING) ! The specfile is written in legible English, but... ... the WTF comment is a bit inapproriate and should preferably be removed, the $libdir/$packagename is a standard place for architecture dependent headers, so its presence is not surprising * Sources matches upstream 962493fd6b26425f21504c3416c4efa1 libsigc++-2.2.2.tar.bz2 962493fd6b26425f21504c3416c4efa1 SRPM/libsigc++-2.2.2.tar.bz2 It is not the latest version (which is 2.2.3), but it is the same as the version currently in Fedora, which the mingw packaging guidelines says it should be. * Package builds in mock (Fedora 10) * BuildRequires look sane * Owns the directories it creates * No duplicate files * %files has %defattr ! two files have questionable permissions and give rpmlint warnings (see above). If possible these two should be fixed by removing executable permissions. * %clean clears %buildroot * Specfile uses macros consistently * Package does not own other's directories * %install clears %buildroot * Installed filenames are valid UTF8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review