Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029 ------- Additional Comments From opensource@xxxxxxxxx 2006-08-23 09:40 EST ------- You use %defattr(-,root,root) instead of %defattr(-,root,root,-) - is this intentionally? Why is there no desktop file as in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191590 ? If you add it, please not inline but in an extra file. Why do you use '%makeinstall' instead of the favoured 'make install DESTDIR="$RPM_BUILD_ROOT"'? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review