Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492690 --- Comment #2 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-28 08:29:35 EDT --- I see the following problems with the spec: - %{_datadir}/%{name} is unowned - Scriptlets are non-standard. Please use standard ones https://fedoraproject.org/wiki/Packaging/ScriptletSnippets - It should have date of last commit in release tag, like "0.4.20090320svn3151%{dist}" https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages - A lot of code is GPLv2+. Is there anything that GPLv2-only? Also license contains exceptions, I asked fedora-legal list about it. It seems to me that "GPLv2+ with exceptions" should be used as license field. And a few minor/cosmetic ones: - Why does it doing build inside %{_target_platform} dir? - Use of --vendor "" is not needed. - You decide to exclude empty files, but are they surely aren’t affect program runtime? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review