Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490039 --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-03-27 16:17:13 EDT --- Some notes: * Documents - Usually "INSTALL" is for people who want to install software by themselves and not needed for people using rpm. And for this package, this "INSTALL" file shows no information. * %defattr - %defattr(644, root, root, 755) is the same as %defattr(-.root,root,-), so this can be removed * rpmlint ---------------------------------------------------------- pyftpdlib.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/pyftpdlib/ftpserver.py 0644 pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/tls_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/test/test_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/unix_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/md5_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/winnt_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/basic_ftpd.py /usr/bin/env pyftpdlib.noarch: W: doc-file-dependency /usr/share/doc/pyftpdlib-0.5.1/demo/throttled_ftpd.py /usr/bin/env ---------------------------------------------------------- - For non-executable-script warning: If this script can be executed directly by users, then this script should have executable permission (i.e. 0755). Otherwise (i.e. if this script is to be called from other program), then the shebang on this script should be removed. This script has __main__ so it seems that this script should have 0755 permission. - About doc-file-dependency This warnings can be removed by explicitly changing permissions under demo/ and test/ directory to 0644 at %prep, like: ---------------------------------------------------------- %prep %setup -q find demo/ test/ -type f | xargs chmod 0644 ---------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review