Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488995 Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #3 from Simon Wesp <cassmodiah@xxxxxxxxxxxxxxxxx> 2009-03-27 07:39:24 EDT --- > https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define > And it's been ratified by FESCo already. > Although in this particular case it doesn't make a difference. https://fedoraproject.org/wiki/Packaging:GuidelinesTodo should be okay. >> please use commands like they are, not as a macro. >> make instead of %{__make} > OK, but what's wrong with using macros? Nothing, it's just a sugestion. I would prefer make, so I tried to convince you. If you don't like it, you can use macros of course, if you want. >> %defattr(644,root,root,755) >> please use %defattr(-,root,root,-) > Why? This is the part you should answer why you are not using %defattr(-,root,root,-) https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions If you have a good reason to differ from default, I will have no problem with this. > You're picky, but OK. I'm definitly not picky. :-) > IIRC it won't, because plugins are dlopen()'d, but I'll re-check. yeah i was wrong, sorry! my fault!!! > No, it has its own implementation. I'm not sure if it makes sense to ask > upstream to use libtlen because libtlen hasn't been updated in quite a while. That puts another complexion on the matter. https://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_libraries If you decide to patch it out, please comment your patch(es) https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review