Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491862 --- Comment #1 from Tejas Dinkar <tejasdinkar@xxxxxxxxx> 2009-03-27 07:08:54 EDT --- This is my first review, and I'm using this guide: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#Things_To_Check_On_Review Points to Check on: * package did NOT build on PPC. Please see http://koji.fedoraproject.org/koji/getfile?taskID=1260790&name=build.log for more details * Is it possible to use %_qt4_plugindir rather than '%define qtplugindir %(qmake-qt4 -query QT_INSTALL_PLUGINS)' Mandatory Tests: * rpmlint passes with no errors or warnings: $ rpmlint SRPMS/kde-style-skulpture-0.2.2-1.fc10.src.rpm RPMS/i386/kde-style-skulpture-0.2.2-1.fc10.i386.rpm RPMS/i386/kde-style-skulpture-debuginfo-0.2.2-1.fc10.i386.rpm SPECS/kde-style-skulpture.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings. * package is named as per Package Naming Guidelines * spec filename matched name * Package meets Packaging Guidelines * Package is GPLv3 licensed * License verified in COPYING file * %doc includes Copying * spec in american english * specfile is legible * sources match the upstream * package compiles on (at least i386) * no ExcludeArch * all dependencies listed * no locales (not needed as this is a theme) * package is not relocatable * package does creates one directory. It uses directories from kde-filesystem (which it depends on implicitly) * no file is listed more than once * permissions correctly set * clean section is correct * package consistently uses macros * package contains only code * no doc subpackage required * %doc files are optional * no header files present, so no -devel package * no static subpackage needed * no pkgconfig files * no library files with a suffix * no -devel package * no .la libtool archives present * package is not a gui application, so need not run desktop-file-install * package does not own files owned by other packages * %install runs rm -rf %{buildroot} * package is UTF-8 valid Optional Items: * Source package contains a COPYING file * No translations in spec file * Package does NOT build on all architecture: http://koji.fedoraproject.org/koji/taskinfo?taskID=1260789 Package fails to build on PPC architecture * Package runs as advertises, and stlye resembles the screenshot upstream * no scriptlets used * no subpackages * no pkgconfig files * package has no file dependencies -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review