Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library https://bugzilla.redhat.com/show_bug.cgi?id=492501 Summary: Review Request: mingw32-libtiff - MinGW Windows port of the LibTIFF library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@xxxxxxxxxxxxxxxxx ReportedBy: ploujj@xxxxxxxxx QAContact: extras-qa@xxxxxxxxxxxxxxxxx CC: notting@xxxxxxxxxx, fedora-package-review@xxxxxxxxxx Estimated Hours: 0.0 Classification: Fedora Spec URL: http://plouj.com/rpmbuild/SPECS/mingw32-libtiff.spec SRPM URL: http://plouj.com/rpmbuild/SRPMS/mingw32-libtiff-3.8.2-13.fc10.src.rpm Hi! I just finished writing the mingw32 libtiff spec file. I used http://cvs.fedoraproject.org/viewvc/rpms/libtiff/devel/libtiff.spec?revision=1.53&view=markup as the basis for this spec file. For your convenience, here is the patch file between the original and my spec: http://plouj.com/rpmbuild/SPECS/libtiff.patch . Some specific questions: Should I keep the "%define LIBVER..." part? Is the multilib hack relevant for mingw cross-compiling libraries? Should I just remove it? I suspect that tiffgt, sgti2tiff and tiffsv don't build unless relevant libraries are available. Should I keep the commands which delete those executables? Currently, I commented them out. Description: The libtiff package contains a library of functions for manipulating TIFF (Tagged Image File Format) image format files. TIFF is a widely used file format for bitmapped images. TIFF files usually end in the .tif extension and they are often quite large. The libtiff package should be installed if you need to manipulate TIFF format image files Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW rpmlint output: $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-libtiff-3.8.2-13.fc10.noarch.rpm mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/tiffvers.h mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/tiffio.h mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a mingw32-libtiff.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/tiffconf.h mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a mingw32-libtiff.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/tiffio.hxx mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/tiff.h mingw32-libtiff.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/tiffconf-64.h mingw32-libtiff.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libtiffxx.dll.a mingw32-libtiff.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libtiff.dll.a mingw32-libtiff.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 1 packages and 0 specfiles checked; 2 errors, 11 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review