Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492019 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #2 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2009-03-26 00:13:20 EDT --- (In reply to comment #0) Amazing, how broken even trivial Makefiles can be ;) MUSTFIX: a) Compilation doesn't acknowledge RPM_OPT_FLAGS. Normally, this can be achieved by overriding the Makefile's CFLAGS: make %{?_smp_mflags} CFLAGS="${RPM_OPT_FLAGS}" However, provided the brokenness of the Makefile, and the simplicity of this package (one single c-file), I am inclined to recommend not to use the Makefile at all, but to compile the file directly: %{__cc} $RPM_OPT_FLAGS -o cfourcc cfourcc.c b) When having changed compilation to using $RPM_OPT_FLAGS, the compiling the package trips over bugs inside of the sources. This breakdown needs patching. c) rpmlint complains: cfourcc.x86_64: W: summary-ended-with-dot Change the FOURCC of an MPEG4 or DivX video. cfourcc.x86_64: E: description-line-too-long With cfourcc you could change the FOURCC of an MPEG4 or DIVX video on the command line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review