Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490380 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rdieter@xxxxxxxxxxxx Flag| |fedora-review+ --- Comment #8 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2009-03-25 08:26:17 EDT --- I'll take a look, but packaging-wise this is pretty simple. Offhand, some of the patches could be reworked to be more upstream'able, but that the can be addressed post-review. sources match upstream: 5478124035d80a90e66a3db67ab4477a qt-creator-1.0.0-src.zip rpmlint output: $ rpmlint *.rpm qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/share/qtcreator/templates/qt4project/mywidget.cpp qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/share/qtcreator/templates/qt4project/mywidget.h qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/share/qtcreator/templates/qt4project/main.cpp qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/share/qtcreator/templates/qt4project/mywidget_form.cpp qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qtcreator/libCPlusPlus.so qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qtcreator/libUtils.so qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qtcreator/libAggregation.so qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qtcreator/libQtConcurrent.so qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qtcreator/libExtensionSystem.so qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/share/qtcreator/templates/qt4project/mywidget_form.h qt-creator.x86_64: W: devel-file-in-non-devel-package /usr/share/qtcreator/gdbmacros/gdbmacros.cpp qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qtcreator ['$ORIGIN/../lib64/qtcreator'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/libQtConcurrent.so.1.0.0 ['$ORIGIN/../lib64/qtcreator'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/libExtensionSystem.so.1.0.0 ['$ORIGIN/../lib64/qtcreator'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/libCPlusPlus.so.1.0.0 ['$ORIGIN/../lib64/qtcreator'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/libAggregation.so.1.0.0 ['$ORIGIN/../lib64/qtcreator'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libQuickOpen.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libDebugger.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libCppTools.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libProjectExplorer.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libQt4ProjectManager.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libDesigner.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libTextEditor.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libCore.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libCMakeProjectManager.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libQtScriptEditor.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libBinEditor.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libHelp.so ['$ORIGIN','$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libVCSBase.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libFind.so ['$ORIGIN','$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libPerforce.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libFakeVim.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libResourceEditor.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libSubversion.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libBookmarks.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libCppEditor.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/plugins/Nokia/libScmGit.so ['$ORIGIN', '$ORIGIN/..', '$ORIGIN/../..'] qt-creator.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/qtcreator/libUtils.so.1.0.0 ['$ORIGIN/../lib64/qtcreator'] 3 packages and 0 specfiles checked; 27 errors, 11 warnings. For now, I'm going to be lenient with the rpaths identified here, but it will be worth investigating on removing some/all of these. The non-devel package warnings are mostly harmless (qt-creator is a developer tool after all). %files: ok License: ok builds: ok (koji) scriptlets: ldconfig isn't needed here, need to add 'update-desktop-database', but that's minor, can fix fixed post-review. .desktop files: passable, can use some work post-review too (for example, Icon= is wrong/doesn't work) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review