[Bug 485915] Review Request: mingw32-wpcap - winpcap library (user level packet capture) for MinGW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485915


Richard W.M. Jones <rjones@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(t.sailer@xxxxxxxx
                   |                            |thz.ch)




--- Comment #3 from Richard W.M. Jones <rjones@xxxxxxxxxx>  2009-03-25 06:41:30 EDT ---
Koji scratch build FAILED:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1257804
This is because the BR should be dos2unix, not unix2dos.

Koji scratch build with updated BR:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1257809

Auto-buildrequires OK.

rpmlint says:
mingw32-wpcap.noarch: W: no-documentation

The license file should be included in %doc.

mingw32-wpcap.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libwpcap.a
mingw32-wpcap.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libpacket.a

These are implibs, so they should be renamed / installed as
libfoo.dll.a

Please fix the above and I'll get round to a formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]