Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491892 --- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-03-25 05:52:37 EDT --- Results of a brief look at the spec: > Source0: %{name}-%{version}.tar.gz Full URL is missing here. > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig These two are automatic/implicit already because -p is used with %post/%postun. > %files > %defattr(-,root,root,-) > %doc AUTHORS COPYING ChangeLog INSTALL NEWS README In case this is the standard 'INSTALL' file, it is irrelevant to RPM package users. > %package devel > License: LGPLv2+ > Requires: pkgconfig > %package python > License: LGPLv2+ > Requires: pkgconfig Neither of these two subpackages need pkg-config. The License tag need not be defined for subpackages as it is copied from the main package. You only need to redefine it if the licence of a subpackage differs from the main pkg actually. Anyone who will review this, %doc docs may need a close look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review