Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491875 --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-03-24 18:00:53 EDT --- - optflags are not used. Use gcc %{optflags} -o unzoo -DSYS_IS_UNIX -O unzoo.c in the build phase. - Move rm -rf %{buildroot} to the top of the install phase. - Drop the creation of the dir and just use install -Dpm 755 unzoo %{buildroot}%{_bindir}/unzoo as this will do the creation for you. - Shipping source code as documentation is silly, please drop it. I see that there is some documentation in the beginning of the source file, please extract it to a text file (remove the unnecessary *'s and so on), ship it as Source1 and put it into %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review