Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481009 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nicolas.mailhot@xxxxxxxxxxx |sshedmak@xxxxxxxxxx Flag|fedora-review? |fedora-review+ --- Comment #4 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-03-24 16:34:39 EDT --- Ok, more review: 1. Your URL metadata field should point to upstream's web site, not directly to the zip (probably http://www.kavya-nandanam.com/dload.htm) 2. It would be better if upstream's added the exact text of the font exception to its licensing file, as the FSF may release another wording someday and then we won't know which one was intended. Though it's already good enough for packaging IMHO. 3. It would be better if upstream used "Regular" or "Normal" as style, most apps won't know what to do with a "Pothana2000" style (I suspect it's the "preferred OTF style" metadata in fontforge ; also opening the font in fontforge results in many warnings) 4. You can drop the "%dir %{_fontdir}" line 5. rpmlint warns of pothana2000-fonts.src: W: mixed-use-of-spaces-and-tabs (spaces: line 36, tab: line 40) 6. 69 should be safe for now. You need to discuss with the packagers of other Telugu fonts in Fedora to decide in common what the best priority should be for this font Anyway nothing blocking here, so I'll approve the package as-is but do try to fix those little problems ⇮⇮⇮ APPROVED ⇮⇮⇮ You can now continue from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a Thank you for packaging a new Fedora font -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review