Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225699 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-03-24 10:34:59 EDT --- Taking on review. A few quick notes: - Is Requires: ldconfig really necessary, as this is part of glibc? - Source should be Source0. - Why do you have --prefix=${RPM_BUILD_ROOT}/usr --sbindir=${RPM_BUILD_ROOT}/sbin --libdir=${RPM_BUILD_ROOT}/%{_libdir} --mandir=${RPM_BUILD_ROOT}/%{_mandir} --includedir=${RPM_BUILD_ROOT}/%{_includedir} as an argument to %configure? Isn't plain %configure with the other extra flags enough? - Also, why do you install -m 755 -d $RPM_BUILD_ROOT{%{_libdir},/sbin,%{_sbindir},%{_bindir},%{_libdir},%{_includedir}/dmraid/,/var/lock/dmraid} isn't this automatically done by make install? - Wouldn't using --enable-shared_lib prevent the need to remove the static library? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review