Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485403 Ray Van Dolson <rayvd@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rayvd@xxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rayvd@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Ray Van Dolson <rayvd@xxxxxxxxxxxx> 2009-03-24 03:49:28 EDT --- Note that correct SRPM URL should be: http://ispbrasil.com.br/ytnef/ytnef-2.6-2.fc10.src.rpm At initial glance, can you change the license to GPLv2+?. Also, it's a little cleaner to use the %{__make}, %{__rm} macros if possible, and you might consider including ChangeLog as part of the documentation. I'll do a formal review tomorrow. Going to bed right now. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review